Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate toolchain build logic #93

Open
lrettig opened this issue Aug 15, 2024 · 0 comments
Open

Remove duplicate toolchain build logic #93

lrettig opened this issue Aug 15, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@lrettig
Copy link
Contributor

lrettig commented Aug 15, 2024

A lot of the logic in cli/src/commands/build_toolchain.rs duplicates logic found in https://github.com/athenavm/rustc-rv32e-toolchain/ clone.sh, build.sh, patch.sh. I left it intact for now since it's probably more platform independent to run some of these commands in Rust rather than using shell scripts, which might e.g. not work on Windows. We should sort this out and remove the duplicate logic.

I fixed one of these issues in #90 / athenavm/rustc-rv32e-toolchain#9 so at least we don't have to specify the Rust commit in two places.

@lrettig lrettig added the help wanted Extra attention is needed label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant