Skip to content

Commit

Permalink
Polish naming convension
Browse files Browse the repository at this point in the history
  • Loading branch information
gonchik committed May 24, 2022
1 parent 7c76c1c commit 2ca8210
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Before you raise a PR
Create the **Commit Header** with the relevant Service Name pre-fixed, examples below,

* Jira: review user module :heavy_check_mark:
* [JIRA] Issues Move to Sprint :heavy_check_mark:
* [Jira] Issues Move to Sprint :heavy_check_mark:
* Confluence: update_page_property method :heavy_check_mark:

An example of a commit message header,
Expand All @@ -59,7 +59,7 @@ An example of a commit message header,

could be better written as,

* [JIRA] Project Issues parameter addition for start and limit :heavy_check_mark:
* [Jira] Project Issues parameter addition for start and limit :heavy_check_mark:

with the commit body have a detail about where/what changes introduced.

Expand Down
4 changes: 3 additions & 1 deletion atlassian/rest_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,9 @@ def raise_for_status(self, response):
if 400 <= response.status_code < 600:
try:
j = response.json()
error_msg = "\n".join(j.get("errorMessages", list()) + [k + ": " + v for k, v in j.get("errors", dict()).items()])
error_msg = "\n".join(
j.get("errorMessages", list()) + [k + ": " + v for k, v in j.get("errors", dict()).items()]
)
except Exception:
response.raise_for_status()
else:
Expand Down

0 comments on commit 2ca8210

Please sign in to comment.