Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname support to pico network driver #1173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Nov 6, 2024

  1. Fix memory leaks in pioc_w network driver

    Fixes a leak in `get_default_device_name()`, if the driver if stopped the memory
    holding the device name is never free'd. This could be especially problematic if
    the driver is stopped and restarted multiple times, as may be the case with a
    battery powered device.
    
    Fixes a potential memory leak of `psk` used for the ap if the given `psk` is
    invalid due to not meeting the minimum size requirement.
    
    Signed-off-by: Winford <winford@object.stream>
    UncleGrumpy committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    31027fa View commit details
    Browse the repository at this point in the history
  2. Add pico_w network driver support for setting dhcp_hostname

    Adds support for setting `dhcp_hostname` from `sta_config_options()` and/or `ap_config_options()`,
    or, if undefined, sets the hostname to the default device name of `atomvm-${DEVICE_MAC}`. Formerly
    all pico_w devices tried to register to an access point with the factory default `PicoW` hostname,
    which would make all subsequent pico devices to connect to an access point, after the first one,
    unreachable by hostname.
    
    Closes atomvm#1094
    
    Signed-off-by: Winford <winford@object.stream>
    UncleGrumpy committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e9ef1ca View commit details
    Browse the repository at this point in the history