Test & readme #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Grummfy
commented
Aug 12, 2017
•
Grummfy
commented
- adding unit test
- adding behaviour test
- fix not found extension bug
- adding readme
agallou
reviewed
Sep 7, 2017
README.md
Outdated
| @@ -0,0 +1,34 @@ | |||
| This repository is the source files for [http://extensions.atoum.org](http://extensions.atoum.org). | |||
|
|
|||
| The purpose is to list extension of atoum and expose it. | |||
|
|
||
| extensions: | ||
| Behat\MinkExtension: | ||
| goutte: ~ |
README.md
Outdated
| ### Test | ||
|
|
||
| ``` | ||
| vendor/bin/robo test |
There was a problem hiding this comment.
where is the robo test command ?
There was a problem hiding this comment.
oups I forget to remove it, I added it, then see that robot need to be updated then see that your libs doesn't support to be updated so roll it back ;)
|
thanks for the review, here is the fix ;) |
|
@agallou tu voix d'autres changements? |
|
@agallou seems ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.