Wait at end of ehal 0.2 blocking SPI writes

atsamd-rs · Aug 21, 2024 · 3d2ba76 · 3d2ba76
1 parent b8de816
commit 3d2ba76
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/hal/CHANGELOG.md b/hal/CHANGELOG.md
@@ -1,5 +1,6 @@
 # Unreleased Changes
 
+- Fix blocking behaviour for `embedded-hal` 0.2 SPI writes
 - Fix I2C transaction to be as continuous as possible according to `embedded-hal` specification
 - Allow configuring USB clock with `GenericClockController` on atsamd11
 - fix samd51j not having i2s support

diff --git a/hal/src/sercom/spi/impl_ehal_thumbv6m.rs b/hal/src/sercom/spi/impl_ehal_thumbv6m.rs
@@ -571,6 +571,8 @@ macro_rules! impl_blocking_spi_write {
                             }
                         }
                     }
+                    // Wait until all data is shifted out
+                    while !self.read_flags().contains(Flags::TXC) {}
                     Ok(())
                 }
             }
@@ -666,6 +668,8 @@ macro_rules! impl_blocking_spi_write_iter {
                             }
                         }
                     }
+                    // Wait until all data is shifted out
+                    while !self.read_flags().contains(Flags::TXC) {}
                     Ok(())
                 }
             }

diff --git a/hal/src/sercom/spi/impl_ehal_thumbv7em.rs b/hal/src/sercom/spi/impl_ehal_thumbv7em.rs
@@ -570,6 +570,8 @@ macro_rules! impl_blocking_spi_write {
                             }
                         }
                     }
+                    // Wait until all data is shifted out
+                    while !self.read_flags().contains(Flags::TXC) {}
                     Ok(())
                 }
             }
@@ -632,7 +634,10 @@ where
             panic!("Slice length does not equal SPI transfer length");
         }
         let sercom = unsafe { self.config.as_ref().sercom() };
-        write_slice(sercom, buf, false)
+        write_slice(sercom, buf, false)?;
+        // Wait until all data is shifted out
+        while !self.read_flags().contains(Flags::TXC) {}
+        Ok(())
     }
 }
 
@@ -687,7 +692,10 @@ where
             panic!("Slice length does not equal SPI transfer length");
         }
         let sercom = unsafe { self.config.as_ref().sercom() };
-        write_slice(sercom, buf, false)
+        write_slice(sercom, buf, false)?;
+        // Wait until all data is shifted out
+        while !self.read_flags().contains(Flags::TXC) {}
+        Ok(())
     }
 }
 
@@ -779,6 +787,8 @@ macro_rules! impl_blocking_spi_write_iter {
                             }
                         }
                     }
+                    // Wait until all data is shifted out
+                    while !self.read_flags().contains(Flags::TXC) {}
                     Ok(())
                 }
             }
-Original file line number
+Diff line change
@@ Expand Up / @@ -571,6 +571,8 @@ macro_rules! impl_blocking_spi_write { @@
                                 }
                             }
                         }
+                        // Wait until all data is shifted out
+                        while !self.read_flags().contains(Flags::TXC) {}
                         Ok(())
                     }
                 }
@@ Expand Down Expand Up / @@ -666,6 +668,8 @@ macro_rules! impl_blocking_spi_write_iter { @@
                                 }
                             }
                         }
+                        // Wait until all data is shifted out
+                        while !self.read_flags().contains(Flags::TXC) {}
                         Ok(())
                     }
                 }
@@ Expand Down @@