Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adafruit matrix portal m4 #713

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

salsasteve
Copy link
Contributor

@salsasteve salsasteve commented Jan 5, 2024

Summary

Created pin mapping for adafruit matrix portal m4 board. Created a blinky basic example.

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

If Adding a new Board

  • Board CI added to crates.json
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1"

If Adding a new cargo feature to the HAL

  • Feature is added to the test matrix for applicable boards / PACs in crates.json

Copy link
Contributor

@jbeaurivage jbeaurivage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. I added a few comments that need to be addressed, but good work in general. Specifically, this board will be a Tier 2, so its dependency on atsamd-hal should not be a path dependency but rather use the crates.io version.

boards/matrix_portal_m4/Cargo.toml Outdated Show resolved Hide resolved
boards/matrix_portal_m4/Cargo.toml Show resolved Hide resolved
boards/matrix_portal_m4/README.md Outdated Show resolved Hide resolved
crates.json Outdated Show resolved Hide resolved
@salsasteve
Copy link
Contributor Author

Thank you for the review. I have fixed the issues above and retested the board again

@salsasteve salsasteve requested a review from jbeaurivage January 8, 2024 20:51
@jbeaurivage
Copy link
Contributor

@salsasteve, I'm sorry, seems like I was mistaken regarding the critical-section-single-core feature. Looks like all other BSPs enable it. Can you please reenable it? Everything else looks good, so I will merge as soon as it's done.

@jbeaurivage jbeaurivage merged commit ceca9d4 into atsamd-rs:master Jan 9, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants