embedded-hal v1 transition
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One question for the reviewer, and the atsamd-hal community at large: how do we feel about removing the |
Might be unnecessary breakage that might be annoying, but otherwise I have no problem with it. |
jbeaurivage
commented
May 1, 2024
Comment on lines
+59
to
81
| impl<TIM: InterruptDrivenTimer> DelayNs for SleepingDelay<TIM> { | ||
| fn delay_ns(&mut self, ns: u32) { | ||
| // Determine how many cycles we need to run for this delay, if any | ||
| // Avoid timers that run longer than a second because for 48 MHz-based timers, | ||
| // there is no valid divisor + cycle count greater than ~1.3s, so we'd panic. | ||
| let mut count: u32 = 1 + (us / NUM_US_IN_S); | ||
| let mut loop_counter: u32 = 1 + (ns / NUM_NS_IN_S); | ||
|
|
||
| // Start the timer and sleep! | ||
| self.timer.start((us / count).nanos()); | ||
| self.timer.start((ns / loop_counter).nanos()); | ||
| self.timer.enable_interrupt(); | ||
| loop { | ||
| asm::wfi(); | ||
| if self.timer.wait().is_ok() || self.interrupt_fired.load(atomic::Ordering::Relaxed) { | ||
| self.interrupt_fired.store(false, atomic::Ordering::Relaxed); | ||
| count -= 1; | ||
| if count == 0 { | ||
| loop_counter -= 1; | ||
| if loop_counter == 0 { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| self.timer.disable_interrupt(); | ||
| } | ||
| } |
There was a problem hiding this comment.
@sajattack, if there's one change I'd like to see get tested on HW, it'd be this one. I'm not sure if this implementation is correct.
sajattack
approved these changes
May 1, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transition some modules to
embedded-halversion 1:embedded-halforgpioembedded-halfori2cembedded-halforspiembedded-hal-nbforspiImplementembedded-ioforspiembedded-hal-nbforuartembedded-ioforuartembedded-hal::DelayNsand adjust timer implementationsembedded-hal::PwmAlso removes the
unprovenCargo feature as it's no longer necessary, and it's been a longtime source of confusion.Supersedes #715.
Closes #332.
Checklist
CHANGELOG.mdfor the BSP or HAL updated#[allow]certain lints where reasonable, but ideally justify those with a short comment.