Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Winc1500 pins #736

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Add Winc1500 pins #736

merged 2 commits into from
Jun 12, 2024

Conversation

kaidokert
Copy link
Contributor

@kaidokert kaidokert commented May 26, 2024

Summary

Added a cargo feature for the board variant with Winc1500 chip and corresponding pins.

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

If Adding a new Board

  • Board CI added to crates.json - not applicable here as this is a board variant, not a new board
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1" - i think it is?

If Adding a new cargo feature to the HAL

  • Feature is added to the test matrix for applicable boards / PACs in crates.json ( unsure how to actually add a BSP/board feature into the matrix )

@kaidokert kaidokert mentioned this pull request May 26, 2024
3 tasks
@kaidokert kaidokert marked this pull request as ready for review June 6, 2024 22:11
@jbeaurivage jbeaurivage merged commit 0fd342e into atsamd-rs:master Jun 12, 2024
107 checks passed
@kaidokert
Copy link
Contributor Author

Thanks for merge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants