Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eic: replace modify with write. prevent losing interrupts in intflag #739

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

mattthebaker
Copy link
Contributor

Summary

Fixes d11 EIC lost interrupt issue, by replacing a couple modify operations with write on registers that were meant mostly for writing. This is in line with the d5x implementation.

Modify on INTENCLR and INTENSET is probably benign, but unnecessary.

Modify on INTFLAG will clear all active bits, not just the channel requesting to be cleared, which leads to lost interrupts.

Checklist

  • [ x] CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items

@jbeaurivage jbeaurivage merged commit 02dbad6 into atsamd-rs:master Jun 5, 2024
92 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants