Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make I2C transactions continuous according to specification (#740) #741

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Make I2C transactions continuous according to specification (#740) #741

merged 1 commit into from
Jun 25, 2024

Conversation

fko-kuptec
Copy link
Contributor

Summary

Changes the implementation of the ehal::i2c::I2c::transaction method to match the specification. The corresponding issue is #740.

I would be thankful if someone could have a look at it, to make sure that it now actually matches the specified behaviour. My code seems works now, but I might have misunderstood something.

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

@jbeaurivage
Copy link
Contributor

jbeaurivage commented Jun 21, 2024

Hi @fko-kuptec, I agree with what you said in #740. Let me check if this PR actually does achieve that, I can potentially test with a logic analyzer some time next week.

@fko-kuptec
Copy link
Contributor Author

fko-kuptec commented Jun 24, 2024

Hi @fko-kuptec, I agree with what you said in #740. Let me check if this PR actually does achieve that, I can potentially test with a logic analyzer some time next week.

Thank you 😊

@jbeaurivage jbeaurivage merged commit 64cb169 into atsamd-rs:master Jun 25, 2024
92 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants