Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USART: Missing events #29

Open
tmplt opened this issue Sep 17, 2022 · 1 comment
Open

USART: Missing events #29

tmplt opened this issue Sep 17, 2022 · 1 comment
Labels
feature Addition of new planned or naturally occuring feature help wanted Extra attention is needed

Comments

@tmplt
Copy link
Member

tmplt commented Sep 17, 2022

Copied from the internal issue tracker. By @martinmortsell:

The current implementation of the USART peripheral only supports at subset of the available interrupt sources.

pub enum Event {
    RxReady,
    TxReady,
    Overrun,
    TxEmpty,
}

The HAL should support more (all?) Event sources.
In particular, I was going to trigger an interrupt on NSSE in SPI mode.

@tmplt
Copy link
Member Author

tmplt commented Sep 17, 2022

I think we'll need to replace the usart::Event with one that takes usart::{spi,uart}::Events:

pub enum Event {
    Spi(spi::Event),
    Uart(uart::Event),
}

and derive strum::FromRepr on the latter. The generics::events::EventHandler implementation will probably have to query the hardware in order to return the correct usart::Event member.

@michalfita michalfita added help wanted Extra attention is needed feature Addition of new planned or naturally occuring feature labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Addition of new planned or naturally occuring feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants