Skip to content

Commit

Permalink
getParameterCount() AAPXS also needs to call send_aapxs_reply().
Browse files Browse the repository at this point in the history
Without it there will not be callback handler invocation, even if the result
is stored on the expected location.
  • Loading branch information
atsushieno committed Nov 7, 2023
1 parent 6f817ef commit b79408b
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ void aap::xs::AAPXSDefinition_Parameters::aapxs_parameters_process_incoming_plug
struct AAPXSDefinition *feature, AAPXSRecipientInstance *aapxsInstance,
AndroidAudioPlugin *plugin, AAPXSRequestContext *request) {
auto ext = (aap_parameters_extension_t*) plugin->get_extension(plugin, AAP_PARAMETERS_EXTENSION_URI);
if (!ext)
return; // FIXME: should there be any global error handling?
switch (request->opcode) {
case OPCODE_PARAMETERS_GET_PARAMETER_COUNT:
*((int32_t*) aapxsInstance->serialization->data) = (ext && ext->get_parameter_count) ? ext->get_parameter_count(ext, plugin) : -1;
aapxsInstance->send_aapxs_reply(aapxsInstance, request);
break;
case OPCODE_PARAMETERS_GET_PARAMETER:
if (ext != nullptr && ext->get_parameter) {
Expand Down

0 comments on commit b79408b

Please sign in to comment.