Converted readiness.py to bash script. #256

andrecolin · 2017-03-08T12:14:22Z

What is the purpose of this pull request?: Replace readiness python script since python not in kolla base image

What issue does this pull request address?: Fixes #253

Notes for reviewers to consider: Still need to convert peerfinder python script next

Specific reviewers for pull request:

wilreichert · 2017-03-08T19:32:58Z

pulled your patch & tested on our cluster with

helm install --name mariadbtest \
--set images.mariadb=kolla/ubuntu-binary-mariadb:3.0.2 \
--set replicas=1 \
--set volume.class_name=ceph \
local/mariadb --namespace=test

Looks like you missed a bash in the deployment.yaml

% kubectl get ev -n test | grep Readiness                                                                                                                 :( 1 17-03-09 - 4:23:01
6s         3m          21        mariadb-0   Pod       spec.containers{mariadb}   Warning   Unhealthy          {kubelet oreo05}       Readiness probe failed: rpc error: code = 2 desc = oci runtime error: exec failed: container_linux.go:247: starting container process caused "exec: \"/tmp/mariadb-readiness.sh\": permission denied"

andrecolin · 2017-03-13T20:55:16Z

@wilreichert Can you pull again and test on your server

wilreichert · 2017-03-15T00:34:56Z

Single instance case above works fine now but clustered still has issues. When launching

helm install --name mariadbtest \
--set images.mariadb=kolla/ubuntu-binary-mariadb:3.0.2 \
--set replicas=3 \
--set volume.class_name=ceph \
local/mariadb --namespace=test

it looks like the peer-finder script has perms isues & init goes bad - pod logs

FWIW, I made sure to nuke pvc's in-between tests.

andrecolin · 2017-03-15T19:25:06Z

@wilreichert There were some extra items in the script bang entry. Can you try again

wilreichert · 2017-03-16T05:41:04Z

hmm, same problem - https://gist.github.com/wilreichert/df413f6ab6ae918bfb747fa6d061978c

intlabs

Minor change required to fix permissions.

intlabs · 2017-03-16T16:47:18Z

mariadb/templates/bin/_seed.sh.tpl

@@ -49,7 +49,7 @@ function wait_for_cluster {
            continue
        fi
        # Count number of endpoint separators.
-        ENDPOINTS_CNT=`python /tmp/peer-finder.py mariadb 1 | grep -o ',' | wc -l`
+        ENDPOINTS_CNT=`/tmp/peer-finder.sh mariadb 1 | grep -o ',' | wc -l`


this line should read: ENDPOINTS_CNT=`bash /tmp/peer-finder.sh mariadb 1 | grep -o ',' | wc -l
which will fix the permissions issue in @wilreichert's linked output.

…er script

andrecolin · 2017-03-17T13:46:11Z

Found two places that did an eval and bash was missing from the eval. Permission issue should be gone
@wilreichert Can you pull again and verify on your servers

andrecolin · 2017-03-22T12:41:32Z

Redoing pull request

Converted readiness.py to bash script.

e559e8d

v1k0d3n added the in progress label Mar 8, 2017

Andre Pollard added 3 commits March 11, 2017 20:22

convert peer-finder.py to bash script peer-finder.sh

3265a45

Fixed readiness probe

0294775

Added code to remove own container IP from list

846ba42

Fixed script bang

9449506

v1k0d3n assigned andrecolin Mar 15, 2017

intlabs suggested changes Mar 16, 2017

View reviewed changes

Found two places that should have had 'bash' before calling peer-find…

73b3878

…er script

andrecolin closed this Mar 22, 2017

v1k0d3n removed the in progress label Mar 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Converted readiness.py to bash script. #256

Converted readiness.py to bash script. #256

andrecolin commented Mar 8, 2017

wilreichert commented Mar 8, 2017

andrecolin commented Mar 13, 2017

wilreichert commented Mar 15, 2017

andrecolin commented Mar 15, 2017

wilreichert commented Mar 16, 2017

intlabs left a comment

intlabs Mar 16, 2017 •

edited

Loading

andrecolin commented Mar 17, 2017 •

edited

Loading

andrecolin commented Mar 22, 2017

Converted readiness.py to bash script. #256

Converted readiness.py to bash script. #256

Conversation

andrecolin commented Mar 8, 2017

wilreichert commented Mar 8, 2017

andrecolin commented Mar 13, 2017

wilreichert commented Mar 15, 2017

andrecolin commented Mar 15, 2017

wilreichert commented Mar 16, 2017

intlabs left a comment

Choose a reason for hiding this comment

intlabs Mar 16, 2017 • edited Loading

Choose a reason for hiding this comment

andrecolin commented Mar 17, 2017 • edited Loading

andrecolin commented Mar 22, 2017

intlabs Mar 16, 2017 •

edited

Loading

andrecolin commented Mar 17, 2017 •

edited

Loading