Skip to content

Commit

Permalink
chore(doc): update maintainer notes
Browse files Browse the repository at this point in the history
  • Loading branch information
bigopon committed May 21, 2022
1 parent 991ad7a commit fdfcde3
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
11 changes: 7 additions & 4 deletions doc/MAINTAINER.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
## Workflow releasing a new version

1. Update: pull latest master with `git pull`
2. Cut release: Run `npm run cut-release {version-type}`. Example:
2. Cut release: Run `npm run cut-release`. Example:

```shell
# with minor
npm run cut-release minor
# automatic versioning
npm run cut-release
# manual version
npm run cut-release -- -- --release-as minor
npm run cut-release -- -- --release-as 1.x.x-beta
```
3. Commit: `git add .` and then `git commit chore(release): prepare release XXX` where `XXX` is the new version
4. Tag: `git tag -a XXX` where `XXX` is the version
4. Tag: `git tag -a XXX -m 'prepare release XXX'` where `XXX` is the version
5. Push to remote repo: `git push --follow-tags`
6. Publish: Run `npm publish` to release the new version
3 changes: 1 addition & 2 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export default [
'aurelia-dependency-injection',
'aurelia-pal',
'aurelia-templating',
// 'aurelia-templating-resources',
'aurelia-task-queue',
'aurelia-logging',
'aurelia-path',
Expand All @@ -63,7 +62,7 @@ export default [
config.output.forEach(output => output.sourcemap = true);
config.onwarn = /** @param {import('rollup').RollupWarning} warning */ (warning, warn) => {
if (warning.code === 'CIRCULAR_DEPENDENCY') return;
warn(warning.message);
warn(warning);
};

return config;
Expand Down
4 changes: 2 additions & 2 deletions src/null-repeat-strategy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
* A strategy for repeating a template over null or undefined (does nothing)
*/
export class NullRepeatStrategy {
instanceChanged(repeat, items) {
instanceChanged(repeat, items): void {
repeat.removeAllViews(true);
}

getCollectionObserver(observerLocator, items) {
getCollectionObserver(observerLocator, items): any {
// empty
}
}

0 comments on commit fdfcde3

Please sign in to comment.