-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Focus): Use handleEvent instead of arrow functions #291
Conversation
Inlined. But I don't why the whole content got blown away and replaced, despite being the same ... Is that an issue ? @EisenbergEffect The API also motivated me to propose aurelia/binding#604, where in each |
@EisenbergEffect @jdanyow I've also put in observer locator to address #273 |
The API is new- it's from aurelia/binding#620 Add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.hasSubscribers = this.observerLocator.getObserver(this, 'value').hasSubscribers())
I don't think we can use this kind of logic to determine whether to add event listeners. Assumes binding order.
I've reverted all the changes. Couldn't think of binding order when attempted to fix that |
This PR replaces 2 arrow functions:
focusListener
&blurListener
byhandleEvent
, leveraging event target interface for lower memory consumption.