feat: Add tfidf #38
Merged
feat: Add tfidf #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tfidf encoder, edited hybrid layer to let user choose sparse encoder type
update sparse_encoder if statements to type rather than name
jamescalam
requested changes
Dec 19, 2023
italianconcerto
approved these changes
Dec 21, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 87.80% 88.60% +0.79%
==========================================
Files 22 23 +1
Lines 894 965 +71
==========================================
+ Hits 785 855 +70
- Misses 109 110 +1 ☔ View full report in Codecov by Sentry. |
jamescalam
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tfidf vectorizer, changed hybrid layer to accomodate, user can define which sparse encoder they use