-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed pinecone tests #414
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 62.53% 67.99% +5.45%
==========================================
Files 46 46
Lines 3465 3465
==========================================
+ Hits 2167 2356 +189
+ Misses 1298 1109 -189 ☔ View full report in Codecov by Sentry. |
User description
PR Type
Bug fix, Tests
Description
pinecone.py
by adding checks for emptyfunction_schemas
and setting them toNone
if empty.layer.py
by adding try-except blocks for route deletion and adjusting dimensions handling.test_layer.py
to verify Pinecone index synchronization and introduced time delays to ensure index population.Changes walkthrough 📝
pinecone.py
Improve synchronization logic and error handling in Pinecone index
semantic_router/index/pinecone.py
function_schemas
and set them toNone
if empty.layer.py
Enhance error handling and logging in route layer
semantic_router/layer.py
_add_and_sync_routes
.test_layer.py
Add and update tests for Pinecone index synchronization
tests/unit/test_layer.py