fix: issue #94 raise from exceptions #105
Conversation
|
Looks good, thanks @alongadot — will run tests |
jamescalam
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 25 25
Lines 1085 1085
=======================================
Hits 990 990
Misses 95 95 ☔ View full report in Codecov by Sentry. |
alongadot
force-pushed
the
issue-94/reraise-exceptions-w-trace
branch
from
30c843b
to
9881ea6
Compare
|
I've corrected the linting issue regarding using Conventional Commits format in the commit message. The build also failed due to a failure in uploading the Codecov report, do you have any advice on that? |
|
@alongadot conventional commits doesn't like the length of your commit message — could you shorten it? For Codecov that's on us, I'm looking into it |
alongadot
force-pushed
the
issue-94/reraise-exceptions-w-trace
branch
from
9881ea6
to
18ec60a
Compare
alongadot
changed the title
|
I see codecov/patch failed - should I add test coverage, given no new statements were actually added? |
|
@alongadot codecov can be difficult 😅 — we have it as optional so I am merging and we'll add coverage for those statements in the future, thanks for the PR! |
Suggestion In order to resolve issue #94
this PR uses the raise from idiom in order to wrap caught exceptions with additional context while preserving their original stack traces.
Notes
The original issue required the exception in semantic-router/semantic_router/llms/openai.py be re-raised, but this PR addresses similar occurrences of this pattern while preserving the additional context added by the new raised exceptions.