Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes ModuleNotFoundError #110

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: Fixes ModuleNotFoundError #110

merged 2 commits into from
Jan 17, 2024

Conversation

bruvduroiu
Copy link
Member

Importing any LLM from semantic_router.llms will cause a ModuleNotFoundError when semantic-router is not installed with the local extra.

Fix this by removing the import of LlamaCppLLM from the __init__.py file. End users will have to import LlamaCppLLM from semantic_router.llms.llamacpp instead.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4ad4d7) 91.25% compared to head (d84ed05) 91.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   91.25%   91.24%   -0.01%     
==========================================
  Files          25       25              
  Lines        1086     1085       -1     
==========================================
- Hits          991      990       -1     
  Misses         95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simjak simjak changed the title Fixes ModuleNotFoundError when not installed with local extras fix: Fixes ModuleNotFoundError Jan 16, 2024
@jamescalam jamescalam merged commit 779072b into main Jan 17, 2024
8 of 9 checks passed
@jamescalam jamescalam deleted the bogdan/fix-llama-import branch January 17, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants