-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added AzureOpenAILLM #112
Conversation
thanks for PR @arashaga — we'll review and get back to you soon |
@arashaga could you add lint tweaks? (can run w/ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 91.25% 91.14% -0.11%
==========================================
Files 25 26 +1
Lines 1086 1129 +43
==========================================
+ Hits 991 1029 +38
- Misses 95 100 +5 ☔ View full report in Codecov by Sentry. |
Done. had a bit of issue using the make lint on Windows but finally figure it out. |
I will add the tests as well. |
@arashaga that'd be great! I think you will be able to take a lot of the OpenAILLM tests and just adopt them for AzureOpenAILLM here, with some small tweaks |
added the unit tests + make lint format. once I see the code coverage report from your end I will modify anything that might be left accordingly. |
now llm/zure.py getting 87% coverage on my end |
Thanks @arashaga will do another review tomorrow morning and hopefully get this merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @arashaga !
The Dynamic routing only worked with OpenAILLM now I added the AzureOpenAILLM class based following the OpenAI one now it works with Azure as well.