fix: README route example simplification #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreped
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 42 42
Lines 2119 2119
=======================================
Hits 1652 1652
Misses 467 467 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that one of the example utterances in one of the routers were unnecessarily complicated.
The utterance will be interpretated as "don't you just love the presidentdon't you just hate the president" in the current format. Could be that the goal was to have one more example in the route, but these two routes are extremely similar, so I see no benefit to it. It would also be one more example in this route compared to the other one.
I therefore chose to simply remove the secondary, redundant utterance.
This change was added in commit:
andreped@ed14f09