Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QdrantIndex #207

Merged
merged 5 commits into from
Mar 20, 2024
Merged

feat: QdrantIndex #207

merged 5 commits into from
Mar 20, 2024

Conversation

Anush008
Copy link
Contributor

Description

This PR adds support for Qdrant to be used as a supported index in Semantic Router.

Testing

The integration tests have been configured to run using an in-memory Qdrant instance if qdrant-client is installed. Skipped otherwise.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 78.20%. Comparing base (931af0c) to head (cd41dd8).

Files Patch % Lines
semantic_router/index/qdrant.py 81.70% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   78.00%   78.20%   +0.19%     
==========================================
  Files          42       43       +1     
  Lines        2146     2234      +88     
==========================================
+ Hits         1674     1747      +73     
- Misses        472      487      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam jamescalam self-requested a review March 18, 2024 04:23
@jamescalam jamescalam self-assigned this Mar 18, 2024
@jamescalam jamescalam added the feature New feature request label Mar 18, 2024
Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Anush008 thanks for the PR this is great! I have a few comments, could we fix those and then we should be good to run tests and merge all being okay, thanks!

semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
semantic_router/index/qdrant.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mesax1 mesax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Passes tests, and the naming conventions follow SemanticRouter conventions of index, metadata, query, dimensions, and config.

Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks all, we appreciate the PR @Anush008!

@jamescalam jamescalam merged commit 9c38431 into aurelio-labs:main Mar 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants