Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add route filtering to indexes #209

Merged
merged 16 commits into from
Apr 1, 2024
Merged

feat: Add route filtering to indexes #209

merged 16 commits into from
Apr 1, 2024

Conversation

zahid-syed
Copy link
Contributor

@zahid-syed zahid-syed commented Mar 19, 2024

Added the ability to filter routes. Initial commit and needs testing

Closes #194

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.18%. Comparing base (ca71efa) to head (f0f2126).

❗ Current head f0f2126 differs from pull request most recent head b88eb99. Consider uploading reports for the commit b88eb99 to get more accurate results

Files Patch % Lines
semantic_router/index/pinecone.py 25.00% 3 Missing ⚠️
semantic_router/index/local.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   78.14%   78.18%   +0.03%     
==========================================
  Files          43       43              
  Lines        2233     2255      +22     
==========================================
+ Hits         1745     1763      +18     
- Misses        488      492       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zahid-syed zahid-syed marked this pull request as ready for review March 20, 2024 14:36
@zahid-syed zahid-syed closed this Mar 20, 2024
@zahid-syed zahid-syed reopened this Mar 20, 2024
@ashraq1455 ashraq1455 changed the title Initial commit to review changes feat: Add filtering capability to RouteLayer.call for specific routes Mar 21, 2024
@ashraq1455 ashraq1455 changed the title feat: Add filtering capability to RouteLayer.call for specific routes feat: Add route filtering to indexes Mar 27, 2024
@ashraq1455 ashraq1455 merged commit a91face into main Apr 1, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to filter for specific routes during RouteLayer.__call__
3 participants