Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cohere type #431

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix: cohere type #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a8091f
Fix types
billytrend-cohere Sep 23, 2024
eb99b61
Lock
billytrend-cohere Sep 23, 2024
a997b97
fix: cohere type
Sep 23, 2024
ed368b1
Merge pull request #430 from billytrend-cohere/fix-type
ashraq1455 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ license = "MIT"
python = ">=3.9,<3.13"
pydantic = "^2.5.3"
openai = ">=1.10.0,<2.0.0"
cohere = ">=5.00,<6.00"
cohere = ">=5.9.4,<6.00"
mistralai= {version = ">=0.0.12,<0.1.0", optional = true}
numpy = "^1.25.2"
colorlog = "^6.8.0"
Expand Down
4 changes: 2 additions & 2 deletions semantic_router/encoders/cohere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import List, Optional

import cohere
from cohere.types.embed_response import EmbedResponse_EmbeddingsByType
from cohere.types.embed_response import EmbeddingsByTypeEmbedResponse

from semantic_router.encoders import BaseEncoder
from semantic_router.utils.defaults import EncoderDefault
Expand Down Expand Up @@ -46,7 +46,7 @@ def __call__(self, docs: List[str]) -> List[List[float]]:
texts=docs, input_type=self.input_type, model=self.name
)
# Check for unsupported type.
if isinstance(embeds, EmbedResponse_EmbeddingsByType):
if isinstance(embeds, EmbeddingsByTypeEmbedResponse):
raise NotImplementedError(
"Handling of EmbedByTypeResponseEmbeddings is not implemented."
)
Expand Down
Loading