Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add fastembed encoder #68

Merged
merged 2 commits into from
Jan 4, 2024
Merged

feat: Add fastembed encoder #68

merged 2 commits into from
Jan 4, 2024

Conversation

kdcokenny
Copy link
Contributor

@kdcokenny kdcokenny commented Jan 4, 2024 •
edited by sync-by-unito bot
Loading

Closes #67

Lmk if there are more tests that should be added or any documentation that would help.

@kdcokenny
Copy link
Contributor Author

kdcokenny commented Jan 4, 2024 •
edited
Loading

I should mention that, the only way I could get pip install fastembed to work was by changing poetry's python version. If anyone knows any workarounds that would be great.

@jamescalam jamescalam added the enhancement Enhancement to existing features label Jan 4, 2024
@jamescalam
Copy link
Member

@kdcokenny awesome! We will review

ashraq1455
ashraq1455 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@ashraq1455 ashraq1455 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @kdcokenny!

@jamescalam jamescalam changed the title Add fastembed encoder feat: Add fastembed encoder Jan 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (97df5ab) 86.51% compared to head (f2f6e5f) 86.52%.

Files Patch % Lines
semantic_router/encoders/fastembed.py 86.20% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   86.51%   86.52%           
=======================================
  Files          14       15    +1     
  Lines         608      638   +30     
=======================================
+ Hits          526      552   +26     
- Misses         82       86    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jamescalam
jamescalam approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @kdcokenny this is great

@jamescalam jamescalam merged commit 412d74c into aurelio-labs:main Jan 4, 2024
5 of 6 checks passed
@kdcokenny kdcokenny deleted the add_fastembed_encoder branch January 4, 2024 17:06
@jamescalam jamescalam mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashraq1455 ashraq1455 ashraq1455 approved these changes

@jamescalam jamescalam jamescalam approved these changes

Assignees

@ashraq1455 ashraq1455

Labels
enhancement Enhancement to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FastEmbed Encoder
3 participants
@kdcokenny @jamescalam @ashraq1455