Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenAI, Cohere and OpenRouter as separate LLMs #79

Merged
merged 9 commits into from
Jan 7, 2024

Conversation

ashraq1455
Copy link
Contributor

@ashraq1455 ashraq1455 commented Jan 6, 2024

No description provided.

@ashraq1455 ashraq1455 changed the title Add OpenAI, Cohere and OpenRouter as separate LLMs feat: Add OpenAI, Cohere and OpenRouter as separate LLMs Jan 6, 2024
@ashraq1455 ashraq1455 marked this pull request as ready for review January 6, 2024 18:43
@jamescalam
Copy link
Member

noting issue #66 which this PR will solve

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (16ebc93) 87.77% compared to head (774b8ed) 87.00%.

Files Patch % Lines
semantic_router/layer.py 44.44% 5 Missing ⚠️
semantic_router/llms/openai.py 85.29% 5 Missing ⚠️
semantic_router/llms/openrouter.py 86.11% 5 Missing ⚠️
semantic_router/utils/function_call.py 50.00% 4 Missing ⚠️
semantic_router/llms/cohere.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   87.77%   87.00%   -0.77%     
==========================================
  Files          16       21       +5     
  Lines         687      816     +129     
==========================================
+ Hits          603      710     +107     
- Misses         84      106      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jamescalam jamescalam merged commit ef11d5d into main Jan 7, 2024
4 of 6 checks passed
@jamescalam jamescalam deleted the ashraq/llm-module branch January 7, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants