Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Compatible with Python 3.9 #92

Merged
merged 15 commits into from
Jan 10, 2024
Merged

feat: Compatible with Python 3.9 #92

merged 15 commits into from
Jan 10, 2024

Conversation

simjak
Copy link
Member

@simjak simjak commented Jan 9, 2024 •
edited
Loading

Added compatibility for 3.9
related to this issue as well #56

@simjak simjak added bug Something isn't working ci labels Jan 9, 2024
@simjak simjak requested a review from jamescalam January 9, 2024 11:09
@simjak simjak self-assigned this Jan 9, 2024
@simjak simjak linked an issue Jan 9, 2024 that may be closed by this pull request
Incompatible with Python 3.12 #86
Open
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f8fcd43) 87.64% compared to head (a359453) 87.80%.

❗ Current head a359453 differs from pull request most recent head c8873e7. Consider uploading reports for the commit c8873e7 to get more accurate results

Files Patch % Lines
semantic_router/utils/llm.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   87.64%   87.80%   +0.16%     
==========================================
  Files          22       22              
  Lines         882      894      +12     
==========================================
+ Hits          773      785      +12     
  Misses        109      109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simjak simjak changed the title feat: Compatible with Python 3.9 and 3.12 feat: Compatible with Python 3.9 Jan 10, 2024
@simjak simjak removed a link to an issue Jan 10, 2024
Incompatible with Python 3.12 #86
Open
@simjak simjak linked an issue Jan 10, 2024 that may be closed by this pull request
Add tests for Python 3.9 #56
Closed
jamescalam
jamescalam approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just had qq on linter, and do we need to change how we lint locally?

.pre-commit-config.yaml Show resolved Hide resolved
@simjak simjak merged commit c122987 into main Jan 10, 2024
6 checks passed
@simjak simjak deleted the simonas/incompatible-with-python-312 branch January 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescalam jamescalam jamescalam approved these changes

@ashraq1455 ashraq1455 Awaiting requested review from ashraq1455

@bruvduroiu bruvduroiu Awaiting requested review from bruvduroiu

Assignees

@simjak simjak

Labels
bug Something isn't working ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for Python 3.9
2 participants
@simjak @jamescalam