Skip to content

Commit

Permalink
chore: apply proposed suggestions by code review
Browse files Browse the repository at this point in the history
  • Loading branch information
aleksuss committed Jul 18, 2023
1 parent beadd82 commit c229509
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions engine/src/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ impl EngineErrorKind {
Self::MaxPriorityGasFeeTooLarge => errors::ERR_MAX_PRIORITY_FEE_GREATER,
Self::GasPayment(e) => e.as_ref(),
Self::GasOverflow => errors::ERR_GAS_OVERFLOW,
Self::NonExistedKey => errors::ERR_FUNCTIONAL_KEY_NOT_FOUND,
Self::NonExistedKey => errors::ERR_FUNCTION_CALL_KEY_NOT_FOUND,
Self::EvmFatal(_) | Self::EvmError(_) => unreachable!(), // unused misc
}
}
Expand Down Expand Up @@ -2293,7 +2293,7 @@ mod tests {
}

#[test]
fn test_add_remove_functional_call_key() {
fn test_add_remove_function_call_key() {
let storage = RefCell::new(Storage::default());
let mut io = StoragePointer(&storage);
let public_key = serde_json::from_str::<RelayerKeyArgs>(
Expand Down
2 changes: 1 addition & 1 deletion engine/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,6 @@ pub const ERR_FAILED_UNREGISTER_ACCOUNT_POSITIVE_BALANCE: &[u8; 46] =
b"ERR_FAILED_UNREGISTER_ACCOUNT_POSITIVE_BALANCE";
pub const ERR_SAME_OWNER: &[u8; 14] = b"ERR_SAME_OWNER";
pub const ERR_SAME_KEY_MANAGER: &[u8] = b"ERR_SAME_KEY_MANAGER";
pub const ERR_FUNCTIONAL_KEY_NOT_FOUND: &[u8] = b"ERR_FUNCTION_CALL_KEY_NOT_FOUND";
pub const ERR_FUNCTION_CALL_KEY_NOT_FOUND: &[u8] = b"ERR_FUNCTION_CALL_KEY_NOT_FOUND";
pub const ERR_KEY_MANAGER_IS_NOT_SET: &[u8] = b"ERR_KEY_MANAGER_IS_NOT_SET";
pub const ERR_ACCOUNTS_COUNTER_OVERFLOW: &str = "ERR_ACCOUNTS_COUNTER_OVERFLOW";

0 comments on commit c229509

Please sign in to comment.