Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use workspace dependencies #790

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

aleksuss
Copy link
Member

Description

The PR adds the possibility to define crate versions used in all crates in the monorepo in workspace.depdndencies section of the main Cargo.toml file.

@aleksuss aleksuss force-pushed the chore/aleksuss/workspace_dependencies branch from 2f7ee51 to eb95165 Compare June 29, 2023 15:06
Copy link
Member

@mrLSD mrLSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@RomanHodulak RomanHodulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, management of the dependencies and other attributes from root Cargo.toml seems convenient and decreases maintainership overhead.

Copy link
Contributor

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know this was a thing! Neat!

@joshuajbouw joshuajbouw added this pull request to the merge queue Jul 11, 2023
Merged via the queue into develop with commit 79cb327 Jul 11, 2023
20 checks passed
@joshuajbouw joshuajbouw deleted the chore/aleksuss/workspace_dependencies branch July 11, 2023 17:45
joshuajbouw added a commit that referenced this pull request Jul 21, 2023
The PR adds the possibility to define crate versions used in all crates
in the monorepo in `workspace.depdndencies` section of the main
`Cargo.toml` file.
joshuajbouw pushed a commit that referenced this pull request Jul 21, 2023
## Description

The PR adds the possibility to define crate versions used in all crates
in the monorepo in `workspace.depdndencies` section of the main
`Cargo.toml` file.
3c8f86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants