fix: push0 should increment program counter by 1 instead of 2 #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksuss
reviewed
Jul 25, 2023
vimpunk
force-pushed
the
fix/shanghai-push0-invalid-pc
branch
from
dc40a3b
to
0ff258c
Compare
vimpunk
changed the title
birchmd
reviewed
Jul 25, 2023
birchmd
approved these changes
Jul 25, 2023
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
aleksuss
approved these changes
Jul 25, 2023
joshuajbouw
pushed a commit
that referenced
this pull request
Jul 27, 2023
## Description The PR bumps the `sputnikvm` version, which contains a bugfix of the `shanghai` implementation. ## Testing Added test which validates EVM transaction created with parameter: `evmVersion: 'shanghai'`. --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Merged
joshuajbouw
added a commit
that referenced
this pull request
Jul 27, 2023
### Fixes - Updated sputnikvm dependency with bugfix in the `shanghai` implementation @mandreyel. #803 --------- Co-authored-by: mandreyel <mandreyel@aurora.dev> Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
mrLSD
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR bumps the
sputnikvmversion, which contains a bugfix of theshanghaiimplementation.Testing
Added test which validates EVM transaction created with parameter:
evmVersion: 'shanghai'.