Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting erc-20 metadata by the owner of the contract #858

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

aleksuss
Copy link
Member

Description

The PR fixes behaviour when the owner of the smart contract can't set ERC-20 metadata in case the account id of the owner and the account id of the contract are different.

Performance / NEAR gas cost considerations

There are no changes in the performance.

Testing

The corresponding test has been added.

engine/src/contract_methods/connector/mod.rs Outdated Show resolved Hide resolved
@aleksuss aleksuss added this pull request to the merge queue Oct 26, 2023
Merged via the queue into develop with commit 5d9c86c Oct 26, 2023
24 checks passed
@aleksuss aleksuss deleted the fix/aleksuss/set_erc20_metadata branch October 26, 2023 16:01
aleksuss added a commit that referenced this pull request Oct 26, 2023
## Description

The PR fixes behaviour when the owner of the smart contract can't set
ERC-20 metadata in case the account id of the owner and the account id
of the contract are different.

## Performance / NEAR gas cost considerations

There are no changes in the performance.

## Testing

The corresponding test has been added.
aleksuss added a commit that referenced this pull request Oct 26, 2023
## Description

The PR fixes behaviour when the owner of the smart contract can't set
ERC-20 metadata in case the account id of the owner and the account id
of the contract are different.

## Performance / NEAR gas cost considerations

There are no changes in the performance.

## Testing

The corresponding test has been added.
@aleksuss aleksuss mentioned this pull request Oct 26, 2023
aleksuss added a commit that referenced this pull request Oct 26, 2023
## Release 3.3.1

### Fixes

- The smart contract owner whose account id is not the same as the
contract account id can set ERC-20 metadata
  by [@aleksuss] ([#858]).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants