Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: a set of minor improvements for engine #916

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Conversation

raventid
Copy link
Contributor

Description

A set of minor changes and clean-ups for overall codebase.

Performance / NEAR gas cost considerations

No changes should affect gas cost.

Testing

Automated tests

How should this be reviewed

Patches are minor and do not introduce any behaviour changes

Copy link
Member

@aleksuss aleksuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good, but there are a couple of nitpicks.

engine-standalone-storage/src/engine_state.rs Outdated Show resolved Hide resolved
engine-standalone-storage/src/lib.rs Outdated Show resolved Hide resolved
engine-standalone-storage/src/relayer_db/mod.rs Outdated Show resolved Hide resolved
@aleksuss aleksuss added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit fbe7f33 Mar 21, 2024
24 checks passed
@aleksuss aleksuss deleted the aur-33-sec-rec branch March 21, 2024 12:04
aleksuss added a commit that referenced this pull request Mar 27, 2024
## Description

A set of minor changes and clean-ups for overall codebase.

## Performance / NEAR gas cost considerations

No changes should affect gas cost. 

## Testing

Automated tests

## How should this be reviewed

Patches are minor and do not introduce any behaviour changes

---------

Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
@aleksuss aleksuss mentioned this pull request Mar 27, 2024
aleksuss added a commit that referenced this pull request Mar 27, 2024
### Additions

- Added a new view transaction `ft_balances_of` for getting balances for
multiple accounts by [@karim-en]. ([#905])

### Changes

- The `ft_resolve_transfer` callback doesn't require running the
contract to finish the `ft_transfer_call` correctly
  by [@aleksuss]. ([#906])
- Borsh has been bumped to 1.3 what allows to get rid of additional
feature `borsh-compat` by [@aleksuss]. ([#907])
- The `ExecutionProfile` has been extended with logs for tests by
[@mrLSD]. ([#910])
- The interface of the engine standalone storage has been extended with
a couple of methods for allowing set/get
  arbitrary data outside the crate by [@aleksuss]. ([#913])

### Fixes

- Minor improvements and fixes by [@raventid]. ([#916])

[#905]: #905
[#906]: #906
[#907]: #907
[#910]: #910
[#913]: #913
[#916]: #916

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Karim <karim@aurora.dev>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: Julian Pokrovsky <raventid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants