Fix(rpc): Estimate gas properly estimates contract deployments #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is the fix in
engine/src/gas.rs. It fixes a bug whereeth_estimateGaswas incorrectly interpreting requests missing thetofield as requests with"to": "0x00". In the EVM, transactions to the zero address are calls whereas transactions without any to field are contract deployments -- this distinction is very important.Additionally, this PR changes the
eth_estiamteGasresponse to add 33% to the value it computes. This gives some buffer in case the on-chain transaction consumes more gas than the local simulation.This PR also includes a test for this fix, which the bulk of the newly added lines of code.