(#106) multiple function call key support #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolga-coplu
previously approved these changes
Aug 4, 2023
| @@ -261,15 +325,23 @@ func (e *EngineEth) asyncSendRawTransaction(txsBytes []byte) (*string, error) { | |||
|
|
|||
| // syncSendRawTransaction submits a raw transaction to engine synchronously | |||
| func (e *EngineEth) syncSendRawTransaction(txsBytes []byte) (*string, error) { | |||
| // check transaction data and return error if any issues (like low gas price or gas limit) | |||
| err := validateRawTransaction(txsBytes, e.Config.EngineConfig) | |||
|
|
|||
There was a problem hiding this comment.
Maybe we can add a deprecated comment on syncSendRawTransaction and asyncSendRawTransaction methods. What do you think?
tolga-coplu
previously approved these changes
Aug 8, 2023
README.md
Outdated
| @@ -96,6 +96,8 @@ for detailed explanation and flags of each command see help | |||
| | endpoint.engine.nearNodeURL | ENDPOINT_ENGINE_NEARNODEURL | user should specify :heavy_exclamation_mark: | ❌ | URL of a Near Node to communicate | | |||
| | endpoint.engine.signer | ENDPOINT_ENGINE_SIGNER | user should specify :heavy_exclamation_mark: | ❌ | to be able to communicate with Near Node, user must have a Near account | | |||
| | endpoint.engine.signerKey | ENDPOINT_ENGINE_SIGNERKEY | user should specify :heavy_exclamation_mark: | ❌ | path to JSON file containing the Near Credentials. To be able to communicate with Near Node, user must have a Near signer key associated to account | | |||
| | endpoint.engine.functionKeyPrefixPattern | ENDPOINT_ENGINE_FUNCTIONKEYPREFIXPATTERN | `fk*.` | ❌ | prefix patter to search for key pair files of Function Call Keys | | |||
tolga-coplu
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.