This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
Sla restart instances #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ridv can you take a look if it works? |
ridv
reviewed
Jul 14, 2021
|
@ridv added the unit test for this abandoned PR :) |
ridv
reviewed
Oct 15, 2021
| jobUpdate := JobUpdateFromConfig(jobConfig.TaskConfig) | ||
| jobUpdate. | ||
| SlaAware(true). | ||
| InstanceCount(jobConfig.InstanceCount) |
There was a problem hiding this comment.
We have to add a small change here to make the scheduler change the config. Let's add a label called `io.github.aurora.restart" with value +1 of the previous value.
| jobUpdate.SlaPolicy(slaPolicy) | ||
| } | ||
| for _, v := range instances { | ||
| jobUpdate.AddInstanceRange(v, v) |
There was a problem hiding this comment.
I don't think we have to set this to anything if we're going to operate on all instances. However, once case here that's pretty interesting is a canary deployment. In fact, that may break this entire idea since each task is tied to a different config in that case :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlaRestartInstances api
How it works:
Tests: