Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update packages #146

Merged
merged 6 commits into from
Aug 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
!/test
!.eslintignore
!.eslintrc.js
!.mocharc.json
!.npmrc
!.prettierrc
!commitlint.config.json
!jest.config.js
!nodemon.json
!package-lock.json
!package.json
Expand Down
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"plugin:import/recommended",
"plugin:import/typescript",
"plugin:@typescript-eslint/recommended",
"plugin:sonarjs/recommended"
"plugin:sonarjs/recommended-legacy"
],
"settings": {
"import/resolver": {
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/continuous_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ steps.nvm.outputs.NODE_VERSION }}
- name: Execute test
run: make test
- name: Install dependencies
run: npm ci
# - name: Execute test
# run: npm test
# env:
# APP_NAME: auth-plus-authentication
- name: SonarCloud Scan
uses: sonarsource/sonarcloud-github-action@master
env:
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ pids
lib-cov

# Coverage directory used by tools like istanbul
coverage
coverage/*
*.lcov

!coverage/lcov.info
# nyc test coverage
.nyc_output

Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run lint:fix
npm run lint
6 changes: 0 additions & 6 deletions .mocharc.json

This file was deleted.

2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.9.0
v20.14.0
3 changes: 2 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
*
!*.ts
!*.json
!*/
!*/
!*.js
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
FROM node:20.9.0-alpine3.18 AS dependency
FROM node:20.12.0-alpine3.18 AS dependency
WORKDIR /app
COPY . .
RUN npm ci

FROM node:20.9.0-alpine3.18 AS builder
FROM node:20.12.0-alpine3.18 AS builder
WORKDIR /app
COPY . .
COPY --from=dependency /app/node_modules ./node_modules
RUN npm run build

FROM node:20.9.0-alpine3.18 AS deploy
FROM node:20.12.0-alpine3.18 AS deploy
WORKDIR /app
COPY --from=dependency /app/node_modules ./node_modules
COPY --from=builder /app/build ./build
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ make infra/up # already create tables based on ./db/migration folder
make infra/down # does not remove volume

# make test on the same condition where it's executed on CI
make test
make ci

# developer and test enviroment
make dev
Expand Down
Loading
Loading