Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added url error code dataNotAllowed as a network error #847

Merged
merged 3 commits into from
May 6, 2024
Merged

fix: added url error code dataNotAllowed as a network error #847

merged 3 commits into from
May 6, 2024

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented May 2, 2024 •
edited
Loading

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

  • Added URLError.Code .dataNotAllowed as a network error and updated unit tests of it.
  • Fixed redirect uri tests when https scheme is enabled for iOS 17.4+ & macOS 14.4+

📎 References

🎯 Testing

  • Tested with Wifi + Mobile Data being turned off and checked the error and it's being returned as a network error

@desusai7 desusai7 linked an issue May 2, 2024 that may be closed by this pull request
isNetworkError does not report case where Wifi + Mobile Data is off #822
Closed
6 tasks
@desusai7 desusai7 marked this pull request as ready for review May 2, 2024 11:28
@desusai7 desusai7 requested a review from a team as a code owner May 2, 2024 11:28
@desusai7 desusai7 merged commit a612d22 into master May 6, 2024
9 checks passed
@desusai7 desusai7 deleted the fix/network_error_internet_disabled branch May 6, 2024 07:02
@desusai7 desusai7 mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isNetworkError does not report case where Wifi + Mobile Data is off
2 participants
@desusai7 @Widcket