Replace gson with Android's org.json.* #77
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
Claim.asArray()
now returnsJSONArray
ornull
Claim.asObject()
now returnsJSONObject
ornull
org.json.*
References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
[ ] This change adds test coverage
[ ] This change has been tested on the latest version of the platform/language or why not
Checklist
[ ] I have read the Auth0 general contribution guidelines
[ ] I have read the Auth0 Code of Conduct
[ ] All existing and new tests complete without errors
Is this something you are willing to merge, if no, the PR can be closed.
If yes, I will continue with the checklist above and look into fixing some of the tests that are currently commented out and/or failing