Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gson with Android's org.json.* #77

Closed
wants to merge 1 commit into from

Conversation

bb441db
Copy link

@bb441db bb441db commented Nov 14, 2023

Changes

Please describe both what is changing and why this is important. Include:

  • Claim.asArray() now returns JSONArray or null
  • Claim.asObject() now returns JSONObject or null
  • Documentation for public API's has not been updated (yet)
  • Replaced the GSON dependency with Android's org.json.*

References

Please include relevant links supporting this change such as a:

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

[ ] This change adds test coverage

[ ] This change has been tested on the latest version of the platform/language or why not

Checklist

[ ] I have read the Auth0 general contribution guidelines

[ ] I have read the Auth0 Code of Conduct

[ ] All existing and new tests complete without errors


Is this something you are willing to merge, if no, the PR can be closed.

If yes, I will continue with the checklist above and look into fixing some of the tests that are currently commented out and/or failing

@poovamraj
Copy link
Contributor

@bb441db this PR is having a lot of breaking changes that we cannot merge directly. This will affect a lot of existing users. I understand the pains caused by GSON and proguard. We will definitely consider this in our future release. But at this point we cannot accept this PR and we will close this.

@poovamraj poovamraj closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants