Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(publish): make contents write and fix secrets reference #604

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ewanharris
Copy link
Contributor

Changes

Comparing with other repos it seems like the permissions and github_token secret were referenced differently, I think that should fix the issue seen when attempting to publish 🤞🏻

References

Please include relevant links supporting this change such as a:

  • support ticket
  • community post
  • StackOverflow post
  • support forum thread

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

Signed-off-by: Ewan Harris <ewan.harris@okta.com>
@adamjmcgrath adamjmcgrath merged commit df551ce into master Feb 26, 2024
15 checks passed
@adamjmcgrath adamjmcgrath deleted the ci/bump-permission-fix-secrets-ref branch February 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants