Merge pull request #201 from authorjapps/kafka_p3_multi

ISS-199 # [On User Demand] POM - Removed Confluent Avro dependency
authorjapps · Feb 4, 2019 · 62b228c · 62b228c
2 parents 7eb0cad + 9ee6b65
commit 62b228c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 23 deletions.
diff --git a/core/pom.xml b/core/pom.xml
@@ -71,10 +71,6 @@
             <groupId>org.apache.kafka</groupId>
             <artifactId>kafka-clients</artifactId>
         </dependency>
-        <dependency>
-            <groupId>io.confluent</groupId>
-            <artifactId>kafka-avro-serializer</artifactId>
-        </dependency>
         <dependency>
             <groupId>org.json</groupId>
             <artifactId>json</artifactId>

diff --git a/...c/test/java/org/jsmart/zerocode/integration/tests/kafka/consume/KafkaConsumeAvroTest.java b/...c/test/java/org/jsmart/zerocode/integration/tests/kafka/consume/KafkaConsumeAvroTest.java
@@ -3,9 +3,12 @@
 import org.jsmart.zerocode.core.domain.JsonTestCase;
 import org.jsmart.zerocode.core.domain.TargetEnv;
 import org.jsmart.zerocode.core.runner.ZeroCodeUnitRunner;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+@Ignore("Users Requested to ignore this until io.confluent:kafka-avro-serializer:5.1.0 becomes available at maven central." +
+        "But to see these tests Passing - Visit repo >> https://github.com/authorjapps/hello-kafka-stream-testing")
 @TargetEnv("kafka_servers/kafka_test_server_avro.properties")
 @RunWith(ZeroCodeUnitRunner.class)
 public class KafkaConsumeAvroTest {

diff --git a/...smart/zerocode/integration/tests/kafka/consume/negative/KafkaConsumeAvroNegativeTest.java b/...smart/zerocode/integration/tests/kafka/consume/negative/KafkaConsumeAvroNegativeTest.java
@@ -3,6 +3,7 @@
 import org.jsmart.zerocode.core.domain.JsonTestCase;
 import org.jsmart.zerocode.core.domain.TargetEnv;
 import org.jsmart.zerocode.core.runner.ZeroCodeUnitRunner;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -15,6 +16,8 @@ public class KafkaConsumeAvroNegativeTest {
     public void testKafkaConsume_avroWrongValue() throws Exception {
     }
 
+    @Ignore("Users Requested to ignore this until io.confluent:kafka-avro-serializer:5.1.0 becomes available at maven central." +
+            "But to see these tests Passing - Visit repo >> https://github.com/authorjapps/hello-kafka-stream-testing")
     @Test
     @JsonTestCase("kafka/consume/negative/test_load_kafka_direct_invalid_avro_msg.json")
     public void testKafkaWrongData_loadDirectTopic() throws Exception {

diff --git a/pom.xml b/pom.xml
@@ -79,7 +79,6 @@
         <h2.db.version>1.4.191</h2.db.version>
         <extentreports.version>3.1.3</extentreports.version>
         <version.kafka-clients>2.1.0</version.kafka-clients>
-        <version.kafka-avro-serializer>5.1.0</version.kafka-avro-serializer>
         <version.gson>2.6.2</version.gson>
         <!-- maven plugin, build properties  -->
         <maven-compiler-plugin.version>3.2</maven-compiler-plugin.version>
@@ -90,13 +89,6 @@
         <maven.javadoc.failOnError>false</maven.javadoc.failOnError>
     </properties>
 
-    <repositories>
-        <repository>
-            <id>confluent</id>
-            <url>http://packages.confluent.io/maven/</url>
-        </repository>
-    </repositories>
-
     <dependencyManagement>
         <dependencies>
             <dependency>
@@ -108,17 +100,6 @@
                 <groupId>org.apache.kafka</groupId>
                 <artifactId>kafka-clients</artifactId>
                 <version>${version.kafka-clients}</version>
-                <!--<exclusions>
-                    <exclusion>
-                        <groupId>org.slf4j</groupId>
-                        <artifactId>slf4j-api</artifactId>
-                    </exclusion>
-                </exclusions>-->
-            </dependency>
-            <dependency>
-                <groupId>io.confluent</groupId>
-                <artifactId>kafka-avro-serializer</artifactId>
-                <version>${version.kafka-avro-serializer}</version>
             </dependency>
             <dependency>
                 <groupId>org.json</groupId>