Add support for reading debug information from the error details #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
reviewed
Jun 13, 2024
internal/commands/permission.go
Outdated
Comment on lines
228
to
234
| if errInfo, ok := grpcErrorInfoFrom(err); ok { | ||
| if encodedDebugInfo, ok := errInfo.Metadata["debug_trace_proto_text"]; ok { | ||
| debugInfo = &v1.DebugInformation{} | ||
| err = prototext.Unmarshal([]byte(encodedDebugInfo), debugInfo) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's please add a test
There was a problem hiding this comment.
The main regression test is on the SpiceDB side but I'll see if I can add a test for parsing the proto here
josephschorr
force-pushed
the
err-debug-info
branch
2 times, most recently
from
31d7df0 to
565d440
Compare
josephschorr
force-pushed
the
err-debug-info
branch
from
565d440 to
be47615
Compare
vroldanbet
approved these changes
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: authzed/spicedb#1930