Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce lookup resources page limit #395

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

vroldanbet
Copy link
Contributor

The new flag is --page-limit. If no limit is specified, it defaults to the original behavior, as it would be a breaking change (e.g. results that did not return duplicates now do).

Under the hood it uses cursoring

this uses LR cursoring. If no limit is specified,
it defaults to the original behaviour, as it would be
a breaking change (e.g. results that did not return
duplicates now do).
@vroldanbet vroldanbet requested a review from josephschorr July 12, 2024 13:20
@vroldanbet vroldanbet self-assigned this Jul 12, 2024
alecmerdler
alecmerdler previously approved these changes Jul 12, 2024
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@vroldanbet vroldanbet force-pushed the introduce-LR-page-limit branch from ebee0f0 to 6a6c01a Compare July 15, 2024 09:07
@vroldanbet vroldanbet requested a review from alecmerdler July 15, 2024 09:08
@vroldanbet vroldanbet added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 0df259a Jul 15, 2024
15 checks passed
@vroldanbet vroldanbet deleted the introduce-LR-page-limit branch July 15, 2024 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
@authzed authzed deleted a comment from jzelinskie Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants