-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathon: The Foxers #133
Conversation
…push_back in the ChunkContainer
Thanks for opening this pull request. Please check out our contributing guidelines. |
Test Results 29 files 29 suites 14m 45s ⏱️ Results for commit 0ba59a9. ♻️ This comment has been updated with latest results. |
Pull Request Test Coverage Report for Build 11867531836Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Results:
|
Closing this PR as key changes have been incorporated into #150, which consolidates contributions from multiple submissions. Thank you all for your efforts! |
Description
Calling check_space only when the condition is met and forcing inlining of push_back in the ChunkContainer eliminates the overhead of the function call stack. Similarly, replacing the fused_multiply_add function directly in the caller function in Tap.cpp removes its overhead.