Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon: The Foxers #133

Closed

Conversation

ayoubHam2000
Copy link
Contributor

Description

Calling check_space only when the condition is met and forcing inlining of push_back in the ChunkContainer eliminates the overhead of the function call stack. Similarly, replacing the fused_multiply_add function directly in the caller function in Tap.cpp removes its overhead.

@boring-cyborg boring-cyborg bot added benchmarks Run benchmark workflow src labels Nov 15, 2024
Copy link

boring-cyborg bot commented Nov 15, 2024

Thanks for opening this pull request. Please check out our contributing guidelines.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Nov 15, 2024

Test Results

    29 files      29 suites   14m 45s ⏱️
 1 319 tests  1 319 ✅ 0 💤 0 ❌
47 823 runs  47 823 ✅ 0 💤 0 ❌

Results for commit 0ba59a9.

♻️ This comment has been updated with latest results.

@coveralls
Copy link
Collaborator

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11867531836

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 98.767%

Totals Coverage Status
Change from base Build 11867528509: 0.04%
Covered Lines: 2404
Relevant Lines: 2434

💛 - Coveralls

@ayoubHam2000 ayoubHam2000 changed the title Optimizing Tape and Chunkcontainer Hackathon: The Foxers Nov 15, 2024
@auto-differentiation-dev
Copy link
Collaborator

Results:

App Reference Optimised Improvement
Monte-Carlo Swaption Pricer (App 1) 13.434s 10.625s 20.910%
Bermudan Swaption Pricer (App 2) 32.49404ms 26.185125ms 19.416%
QuantLib Overhead (App 3) 4043716ms 4181615ms -3.410%

@auto-differentiation-dev
Copy link
Collaborator

Closing this PR as key changes have been incorporated into #150, which consolidates contributions from multiple submissions. Thank you all for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Run benchmark workflow src
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants