-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some comparison errors for Jacobian functions #146
Fixed some comparison errors for Jacobian functions #146
Conversation
Test Results 29 files 29 suites 14m 40s ⏱️ Results for commit 54726f3. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that.
Could you use std::size_t
for the type instead? This is also the type used for the size_type
of STL containers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few simplifications, then it's good to go
Head branch was pushed to by a user without write access
5866282
into
auto-differentiation:main
Type of change
Simple recast on some comparisons that triggered warnings with MSVC2022.