Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some comparison errors for Jacobian functions #146

Merged

Conversation

raneamri
Copy link
Contributor

Type of change

Simple recast on some comparisons that triggered warnings with MSVC2022.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

github-actions bot commented Nov 17, 2024

Test Results

    29 files      29 suites   14m 40s ⏱️
 1 319 tests  1 319 ✅ 0 💤 0 ❌
48 311 runs  48 311 ✅ 0 💤 0 ❌

Results for commit 54726f3.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@xcelerit-team xcelerit-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that.

Could you use std::size_t for the type instead? This is also the type used for the size_type of STL containers.

Copy link
Collaborator

@auto-differentiation-dev auto-differentiation-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few simplifications, then it's good to go

src/XAD/Hessian.hpp Outdated Show resolved Hide resolved
src/XAD/Hessian.hpp Outdated Show resolved Hide resolved
src/XAD/Jacobian.hpp Outdated Show resolved Hide resolved
src/XAD/Jacobian.hpp Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 18, 2024 17:42

Head branch was pushed to by a user without write access

@auto-differentiation-dev auto-differentiation-dev merged commit 5866282 into auto-differentiation:main Nov 18, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants