(POC) Rethinking type_owners table #14
Conversation
|
|
||
| public void deleteOmniTypeById(Long id) { | ||
| log.info("Delete omni type by data type [{}]", id); | ||
| omniTypeRepository.deleteById(id); |
There was a problem hiding this comment.
pls check if it's exist or throw notFoundException
|
|
||
| Long id; | ||
| String dataType; | ||
| String meta; |
There was a problem hiding this comment.
what format of data we will store in metadata? I thought it will be Map<String, Object> meta and json in db
There was a problem hiding this comment.
let's start with String and once we need to implement specific logic, we can change it
- integrate OmniType with Omni in TestDataStorageService - update migration - update tests - remove purgeAllData
| Long id; | ||
| String dataType; | ||
| String meta; | ||
| LocalDateTime created; | ||
| LocalDateTime updated; |
There was a problem hiding this comment.
| Long id; | |
| String dataType; | |
| String meta; | |
| LocalDateTime created; | |
| LocalDateTime updated; | |
| private Long id; | |
| private String dataType; | |
| private String meta; | |
| private LocalDateTime created; | |
| private LocalDateTime updated; |
| @@ -14,14 +16,24 @@ | |||
| @RequiredArgsConstructor | |||
There was a problem hiding this comment.
constructor not needed here since all methods are static
the class can be marked as @UtilityClass
| var omniType = getOmniTypeIfExists(dataType); | ||
| var omni = Omni.builder() | ||
| .data(data) | ||
| .omniType(omniType) | ||
| .archived(false) | ||
| .created(LocalDateTime.now()) |
There was a problem hiding this comment.
a point for future improvement - created can be set automatically by Jpa audit
| var omnis = omniRepository.findAllByOmniTypeAndCreatedBefore(omniType, archiveOmniDTO.getCreatedBefore()); | ||
| if (!omnis.isEmpty()) { | ||
| omnis.forEach(omni -> { | ||
| omni.setUpdated(LocalDateTime.now()); |
There was a problem hiding this comment.
same - updated can be set by @ModifiedDate and JPA audit
make EntityMapper annotated with UtilityClass
| @@ -1,15 +1,12 @@ | |||
| package com.auto1.testdatastorage.service; | |||
There was a problem hiding this comment.
there should be 2 separate service classes:
- OmniQueueItemService
- OmniTypeService
There was a problem hiding this comment.
ok, will do separation
separate TestDataStorageController to OmniQueueController.java and OmniTypeController.java
Create new table omni_type instead of type_owners
Add new endpoints:
-POST /queue/omni-type - Create omni type
-PUT /queue/omni-type/{id} - Update omni type
-DELETE /queue/omni-type/{id} - Delete omni type
-GET /queue/omni-types - Get all omni types
Add tests