Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch windows to using native-reg to avoid permissions #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nokel81
Copy link

@Nokel81 Nokel81 commented Jul 7, 2021

Signed-off-by: Sebastian Malton sebastian@malton.name

fixes #56

Changes:

  • changing the code to be typescript
  • updating the package.json to reflect that change.
  • Fix the list and test scripts to run on windows git bash

Major change:

  • remove the calling of the reg.exe executable as that requires admin permissions. The native-reg package provides a JS compatible API to get the registry keys themselves.

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@weizhanzhan
Copy link

How do I use it

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Copy link
Author

Nokel81 commented Oct 26, 2021

@weizhanzhan I don't understand what you are asking? We have to wait for @automation-stack to approve this PR before it would get merged.

@Rambarani
Copy link

When this PR will be merged @automation-stack

@adambailey-
Copy link

I also need this changeset merged! @automation-stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command failed: Registry editing has been disabled by your administrator.
4 participants