Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix small bug that creped in during merge conflict #669

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix small bug that creped in during merge conflict #669

merged 1 commit into from
Jun 25, 2024

Conversation

marc-aurele-besner
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner commented Jun 25, 2024 •
edited by github-actions bot
Loading

User description

fix small bug that creped in during merge conflict

PR Type

Bug fix

Description

  • Corrected the naming of the signingKey field to signingKeySeed in the OperatorStake component.
  • Updated the placeholder text and error handling to match the new field name.

Changes walkthrough 📝

Relevant files
Bug fix
OperatorStake.tsx
Fix naming inconsistency for signing key seed field           

explorer/src/components/Operator/OperatorStake.tsx

  • Corrected the naming of the signingKey field to signingKeySeed.
  • Updated placeholder text to match the new field name.
  • Adjusted error handling to reflect the new field name.
    		•  +5/-5     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @netlify Netlify
    Copy link

    netlify bot commented Jun 25, 2024 •
    edited
    Loading

    ✅ Deploy Preview for dev-astral ready!

    Name Link
    🔨 Latest commit ebd62df
    🔍 Latest deploy log https://app.netlify.com/sites/dev-astral/deploys/667b11ac969c2b0008a08bcb
    😎 Deploy Preview https://deploy-preview-669--dev-astral.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @github-actions GitHub Actions
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 2
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    @github-actions GitHub Actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for PR.

    EmilFattakhov
    EmilFattakhov approved these changes Jun 25, 2024
    View reviewed changes
    Copy link
    Contributor

    @EmilFattakhov EmilFattakhov left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks Marc!

    @marc-aurele-besner marc-aurele-besner merged commit 661a9bd into main Jun 25, 2024
    14 checks passed
    @marc-aurele-besner marc-aurele-besner deleted the bug/registerWithSeed branch June 25, 2024 20:35
    @marc-aurele-besner marc-aurele-besner mentioned this pull request Jun 25, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @EmilFattakhov EmilFattakhov EmilFattakhov approved these changes

    @jfrank-summit jfrank-summit Awaiting requested review from jfrank-summit

    Assignees
    No one assigned
    Labels
    Bug fix Review effort [1-5]: 2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @marc-aurele-besner @EmilFattakhov