Role assignation fail

[marc-aurele-besner]

User description

Role assignation fail

---

PR Type

Bug fix, Enhancement

---

Description

• Simplified the logic in ChainProvider by removing the cookie-based network setting and directly using indexerSet.network.
• Enhanced queryGraphqlServer to extract the network ID from the callback URL instead of relying on cookies, improving reliability and error handling.

---

Changes walkthrough 📝

	Relevant files
Enhancement	ChainProvider.tsx Simplify network selection logic in ChainProvider                explorer/src/providers/ChainProvider.tsx Removed cookie setting logic for network selection. Simplified state management by directly using indexerSet.network. Removed unnecessary network state variable. +1/-5
Bug fix	queryGraphqlServer.ts Use callback URL for network ID extraction in GraphQL queries explorer/src/utils/queryGraphqlServer.ts Replaced cookie-based network selection with callback URL parsing. Extracted network ID from callback URL for API selection. Improved error handling for missing callback URL or network ID. +9/-3

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[netlify]

✅ Deploy Preview for dev-astral ready!

Name	Link
🔨 Latest commit	117d138
🔍 Latest deploy log	https://app.netlify.com/sites/dev-astral/deploys/66d5cdf7c5b24a00089887ef
😎 Deploy Preview	https://deploy-preview-839--dev-astral.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Error Handling The error handling for 'No network ID found in callback URL' might not be sufficient. Consider adding more detailed error messages or handling specific cases more gracefully. Possible Bug The extraction of 'networkId' from the URL assumes a specific URL structure which might not always be valid. This could lead to incorrect or failed network ID extraction.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Improve error handling for network ID extraction Add error handling for the case where url.pathname.split('/')[1] does not return a valid network ID, to prevent runtime errors. explorer/src/utils/queryGraphqlServer.ts [14-15] -const networkId = url.pathname.split('/')[1] // The network ID is the second part of the path -if (!networkId) throw new Error('No network ID found in callback URL') +const pathParts = url.pathname.split('/'); +const networkId = pathParts.length > 1 ? pathParts[1] : null; +if (!networkId) throw new Error('No network ID found in callback URL'); Suggestion importance[1-10]: 8 Why: This suggestion addresses a potential runtime error by adding a check for the length of the path parts, which is a significant improvement in error handling.	8
Enhancement	Provide more detailed error messages Use a more specific error message when api is not found, indicating the missing network ID. explorer/src/utils/queryGraphqlServer.ts [19] -if (!api) throw new Error('No selected chain api') +if (!api) throw new Error(`No selected chain api for network ID: ${networkId}`) Suggestion importance[1-10]: 7 Why: The suggestion enhances the error message by including the missing network ID, which improves debugging but is not critical for functionality.	7
Best practice	Use destructuring to access properties from indexerSet Replace the direct access of indexerSet.network with a destructured variable for consistency and clarity. explorer/src/providers/ChainProvider.tsx [78] -network: indexerSet.network, +const { network } = indexerSet; +network: network, Suggestion importance[1-10]: 5 Why: The suggestion improves code readability by using destructuring, but it is not crucial as the current code is already clear and functional.	5

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Protestware/Troll package	npm/es5-ext@0.10.64	Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale	indexers/staking-squid/package-lock.json indexers/staking-squid/package.json	⚠︎

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/es5-ext@0.10.64

[EmilFattakhov]

Can't confirm the fix on preview @marc-aurele-besner, but should be okay to test in prod.

[marc-aurele-besner]

Can't confirm the fix on preview @marc-aurele-besner, but should be okay to test in prod.

Now it should work in the preview, but you will not be able to test the full flow in a preview since you will be redirected back to the production domain after connecting to Discord.

[socket-security]

Report too large to display inline

View full report↗︎