Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ads #9

Merged
merged 3 commits into from
Sep 26, 2023
Merged

remove ads #9

merged 3 commits into from
Sep 26, 2023

Conversation

marc-aurele-besner
Copy link

remove ads

  • Simply change the logic of all ads components to return null to reduce code disparity with forked branch

dnoishi
dnoishi suggested changes Sep 25, 2023
View reviewed changes
Copy link

@dnoishi dnoishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this Marc.

Instead of returning null for each ad banner, I think removing these components and every call to any of them is better.

dnoishi
dnoishi approved these changes Sep 26, 2023
View reviewed changes
Copy link

@dnoishi dnoishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@marc-aurele-besner marc-aurele-besner merged commit 4fbbd30 into subspace-frontend Sep 26, 2023
1 check passed
@dnoishi dnoishi linked an issue Sep 27, 2023 that may be closed by this pull request
Remove Ads banner in block scout frontend #3
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnoishi dnoishi dnoishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Ads banner in block scout frontend
2 participants
@marc-aurele-besner @dnoishi