Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homebrew formulae #1

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Add homebrew formulae #1

merged 4 commits into from
Jan 28, 2024

Conversation

abhi3700
Copy link
Contributor

@abhi3700 abhi3700 commented Jan 25, 2024

Description

This PR is to add Homebrew formulae for pulsar, facilitating easy installation on macOS.

As the installation can be done based on the formulae pulsar.rb code on main branch, so I tested via pushing the PR's code to another dummy repo.

Tested OK ✅

With this PR, this issue can be resolved.

@abhi3700 abhi3700 self-assigned this Jan 25, 2024
@abhi3700 abhi3700 added the enhancement New feature or request label Jan 25, 2024
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused, do you expect this to still be a separate repo? I expected this to be submitted to the Pulsar itself.

@abhi3700
Copy link
Contributor Author

abhi3700 commented Jan 26, 2024

@nazar-pc

I'm a bit confused, do you expect this to still be a separate repo? I expected this to be submitted to the Pulsar itself.

The intent is to make the pulsar.rb file hosted somewhere (as repo) & keep user away from downloading the entire pulsar repo so as to make the process look simple.

Not saying we can't do with pulsar repo though.

Let me know your thoughts.

@nazar-pc
Copy link
Member

I see, what about an automation that would push a commit to a gh-pages branch after new macOS build of Pulsar is out? That way we don't need to update it manually ever again and GitHub Pages will take care of hosting it and avoid downloading the whole repo (that is assuming "static website" is a supported way in homebrew).

@abhi3700
Copy link
Contributor Author

abhi3700 commented Jan 28, 2024

I see, what about an automation that would push a commit to a gh-pages branch after new macOS build of Pulsar is out? That way we don't need to update it manually ever again and GitHub Pages will take care of hosting it and avoid downloading the whole repo (that is assuming "static website" is a supported way in homebrew).

I was thinking for a while & also confirmed with @DaMandal0rian:

  • Homebrew doesn't support static gh-page.
  • Homebrew should be hosted on a separate repo as done here.

Putting here @DaMandal0rian's plan:

"Basically, I would trigger a job when new pulsar release is out, it dispatches the tag and sha to the homebrew repo, homebrew repo has an action to build the new formulae, and then a PR is opened by that action, then enable auto merge on the action so PRs are merged automatically if requirement checks pass. Alternatively, there is an action that does this without needing to dispatch data and will shorten the process.
https://github.com/marketplace/actions/bump-homebrew-formula "

I will let @DaMandal0rian take over from here.

@nazar-pc
Copy link
Member

"Basically, I would trigger a job when new pulsar release is out, it dispatches the tag and sha to the homebrew repo, homebrew repo has an action to build the new formulae, and then a PR is opened by that action, then enable auto merge on the action so PRs are merged automatically if requirement checks pass. Alternatively, there is an action that does this without needing to dispatch data and will shorten the process.
https://github.com/marketplace/actions/bump-homebrew-formula "

I like this plan!

@abhi3700
Copy link
Contributor Author

abhi3700 commented Jan 28, 2024

@nazar-pc
Can we merge this PR for the current release 0.7.4?

I will open an issue with @DaMandal0rian's plan, which can be submitted as another PR.

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are keeping this repo, yes. Thanks for doing this!

@abhi3700 abhi3700 merged commit 9fe606e into main Jan 28, 2024
1 check passed
@nazar-pc nazar-pc deleted the add-homebrew-formulae branch January 28, 2024 22:42
@DaMandal0rian
Copy link

@abhi3700 I think you tagged the wrong person 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants